feat: Warn when unsupported OIDC client auth method is configured#877
Merged
feat: Warn when unsupported OIDC client auth method is configured#877
Conversation
5 tasks
razvan
previously approved these changes
Apr 7, 2026
razvan
approved these changes
Apr 7, 2026
sbernauer
reviewed
Apr 8, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trino does not support configuring the OIDC client authentication method. With the new
clientAuthenticationMethodfield added to the AuthenticationClass CRD in operator-rs 0.109.0, users could set it without realizing it has no effect.This PR emits a warning log when a non-default OIDC client authentication method is configured, so users are aware the setting will be ignored.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker